This repository has been archived by the owner on Nov 29, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 8
feat: add global drag and drop function to the editor #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
f2c-ci-robot
bot
added
release-note
Denotes a PR that will be considered when it comes time to generate release notes.
kind/feature
Categorizes issue or PR as related to a new feature.
do-not-merge/work-in-progress
Indicates that a PR should not merge because it is a work in progress.
labels
Sep 14, 2023
/retitle feat: add global drag and drop function to the editor |
f2c-ci-robot
bot
changed the title
WIP: feat: add global drag and drop function to the editor
feat: add global drag and drop function to the editor
Sep 18, 2023
f2c-ci-robot
bot
removed
the
do-not-merge/work-in-progress
Indicates that a PR should not merge because it is a work in progress.
label
Sep 18, 2023
f2c-ci-robot
bot
removed
the
do-not-merge/hold
Indicates that a PR should not merge because someone has issued a /hold command.
label
Sep 22, 2023
JohnNiang
reviewed
Sep 25, 2023
JohnNiang
approved these changes
Sep 25, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
f2c-ci-robot
bot
added
the
approved
Indicates a PR has been approved by an approver from all required OWNERS files.
label
Sep 25, 2023
JohnNiang
approved these changes
Sep 26, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JohnNiang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
approved
Indicates a PR has been approved by an approver from all required OWNERS files.
kind/feature
Categorizes issue or PR as related to a new feature.
lgtm
Indicates that a PR is ready to be merged.
release-note
Denotes a PR that will be considered when it comes time to generate release notes.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
为编辑器中所有元素增加了拖拽功能,将可以拖拽任意元素的顺序。
默认情况下,拖拽功能会被禁用,只有当扩展实现了
getDraggable
时才会使元素可拖拽。TODO:
How to test it?
Which issue(s) this PR fixes:
Fixes #46
Does this PR introduce a user-facing change?